-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add frameworks tests to windows job #7032
Conversation
9e1a0c5
to
d4889d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7032 +/- ##
==========================================
+ Coverage 54.79% 54.84% +0.05%
==========================================
Files 359 361 +2
Lines 25110 25223 +113
Branches 5176 5202 +26
==========================================
+ Hits 13758 13834 +76
- Misses 10114 10145 +31
- Partials 1238 1244 +6 ☔ View full report in Codecov by Sentry. |
f530050
to
a8ab026
Compare
a8ab026
to
e7785c0
Compare
a34adad
to
d133abf
Compare
d133abf
to
c922e0d
Compare
c4d2992
to
409753c
Compare
409753c
to
e57c355
Compare
expect(apiStaticResponse.headers.get("custom-header")).to.eql("custom-value"); | ||
expect(await apiStaticResponse.json()).to.eql(apiStaticJSON); | ||
|
||
// TODO(leoortizz|jamesdaniels): Figure out why custmo headeres aren't wokring with emulators in Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesdaniels I couldn't figure out why but the headers are incorrect when running with the emulators on Windows. content-type
is false
and custom-header
is null
avoid confusion with Node.js `path.sep`
Description
Add frameworks tests on windows to CI. Mainly fix paths to work on Windows.
Scenarios Tested
Sample Commands